Re: [PATCH] add location button context menu

[Christian Neumair <chris gnome-de org>]

Am Samstag, den 30.04.2005, 21:56 +0200 schrieb J�lleter:
> On Fre, 2005-04-29 at 22:06 +0200, Christian Neumair wrote:
> > This is the second version of a patch I've submitted about 2.5 months
> > ago to nautilus-list [1]. There were no direct followups, but I was now
> > asked to update the patch, though, so it looks like people are
> > interested in it.selection
> > The new version only has the Cut, Copy, Paste, Trash + Delete and
> > Properties items in the context menu, but - in contrast to the last
> > version - doesn't make nautilus spit out g_warnings. selectionAlso, I've added a
> > context menu to the navigation view "Location:" label.
> > Comments, suggestions?

Thanks for your feedback, I'm currently redoing my patch a bit.

> Some comments / bugs:

> - Whenever I choose "Copy" in your new menu and then double click on a
> subfolder, nautilus crashes (can provide stack trace if you can't
> reproduce it)

Fixed, same for "Cut". The reason was that the copy_or_cut_files helper
frees the files itself. No need to free it again.

> - Sensitivity of the "Cut", "Move to Trash", and "Delete" actions seems
> to be wrong. "Cut" is always sensitive but should probably only be
> sensitive when "Move to Trash" and "Delete" are.

In my new version, they are all sensitive when
fm_directory_view_is_read_only returns FALSE.

> "Move to Trash" is sensitive when the _current_ folder is not read only
> but it should look at the _parent_ folder.

Should it? If nautilus_file_can_write is true for a subfolder, but not
for the parent folder, will I be able to move the subfolder to trash?

> "Delete" is currently sensitive when the current
> folder _is_ read only ;) but should of course behave the same way as
> "Move to Trash".

Scary. Fixed as well.

> - Browser mode: Are you sure that the URI check in
> label_button_pressed_callback is right? At first sight it seems like
> your comparing the location label, not the URI entry (i.e. you seem to
> compare "Location:" with "Location:").

Yup, it is totally right, since it is only set if
gnome_vfs_uris_match (bar->details->last_location, current_location) is
true. I was convinced that a strcmp is less expensive than an URI
comparison.

-- 
Christian Neumair <chris gnome-de org>