Re: Use of maintainer mode in GNOME modules

[Javier Jardón <jjardon gnome org>]

On 14 September 2011 11:43, Milan Crha <mcrha redhat com> wrote:
> On Wed, 2011-09-14 at 10:56 +0100, Ross Burton wrote:
>>
>> "maintainer mode" shouldn't mean anything else apart from changing how
>> the makefiles generate, and certainly shouldn't change what code is
>> being compiled.
>
>        Hi,
> why is that? I can imagine couple useful things being tight to the
> maintainer mode, also those aforementioned deprecated stuff being in use
> only for maintainers, not for regular users, like is done here [1].
> Other users in this thread gave also reasonable examples of a usage of
> the maintainer mode, not only for a makefile generation.
>        Bye,
>        Milan
>
> [1] http://git.gnome.org/browse/bug-buddy/tree/configure.in#n101

What you are doing there is pretty disconnected from what
AM_MAINTAINER_MODE does. They share a nebulous concept of a "maintainer mode",
but they're doing very different things.
As Rob said, "maintainer mode" shouldn't mean anything else apart from
changing how
the makefiles generate, and certainly shouldn't change what code is
being compiled.

We are working in a new macro [1] to fix this use case. As a temporary
solution you can use this in your configure.ac:

dnl ---------------------------------------------------------------------------
dnl - Use strict options (default enabled for devs, disabled in releases)
dnl ---------------------------------------------------------------------------
dnl if .git directory is present, considering we are working in the repository

test -d "$(srcdir)/.git"; then
        default_strict=yes
else
        default_strict=no
fi

AC_ARG_ENABLE([strict],
              [AS_HELP_STRING([--enable-strict],
                              [Enable strict compilation options])],
              [enable_strict=$enableval],
              [enable_strict=$default_strict])

if test x$enable_strict != xno; then
    CPPFLAGS="$CPPFLAGS -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED
-DGDK_DISABLE_DEPRECATED"
fi

[1] https://bugzilla.gnome.org/show_bug.cgi?id=658608

-- 
Javier Jardón Cabezas