Re: Bug #60014 Fix



Currently a NULL shell is handled fine, as the code first checks the env
var, then the passwd struct for the user, then finally just tries to
find one on the file system.

It would be pretty easy to add a check for a zero-length shell var in
the same logic that checks for a NULL one.  I'll write one tomorrow, as
I think this is a much more elegant solution, as it fixes the problem
rather than just throwing an error dialog.

On Fri, 2001-09-14 at 17:51, Havoc Pennington wrote:
> 
> 
> jacob berkman <jacob ximian com> writes: 
> > would it be safe / ok to try other probably-good shells before popping
> > the error message?
> >
> 
> Yeah I think it'd be fine to just fall back to something instead of an
> error message.
>  
> > what's the RH bug #?
> 
> I was on crack, I remembered this from the GNOME tracker ;-)
>   http://bugzilla.gnome.org/show_bug.cgi?id=60014
> 
> (which is why Cory fixed it I guess)
> 
> Havoc
> 
> _______________________________________________
> gnome-devel-list mailing list
> gnome-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-devel-list
> 
> 






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]